Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong autocorrect for Rails/FilePath when passing an array to File.join #1326

Merged

Conversation

Earlopain
Copy link
Contributor

File.join actually accepts nested arrays and will unflatten them as necessary.

Don't bother implementing autocorrect for these cases, seems complicated and not worth the effort.

The current correction for these testcases look like this:

Rails.root.join().to_s

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…File.join`

`File.join` actually accepts nested arrays and will unflatten them as necessary.

Don't bother implementing autocorrect for these cases, seems complicated
and not worth the effort.

The current correction for these testcases look like this:
```rb
Rails.root.join().to_s
```
@koic koic merged commit 4a00257 into rubocop:master Sep 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants